Get current namespace when parent namespace is empty string #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @ibash, please merge your commits into a single one so I can merge your PR as requested in our Guidelines for Submitting a Pull Request 👍 |
…lim/node-soap/issues/533
|
Squashed and rebased onto latest master. @herom I noticed that my last build failed on node 12: https://travis-ci.org/vpulim/node-soap/jobs/63788061 Thanks! |
|
Thanks @ibash 👍 I've seen TravisCI builds fail without any reason (last time it failed when testing a PR that only changed our license entry in the |
herom
added a commit
that referenced
this pull request
May 26, 2015
Get current namespace when parent namespace is empty string
diarmaidm
pushed a commit
to diarmaidm/node-soap
that referenced
this pull request
Feb 3, 2016
Get current namespace when parent namespace is empty string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue: #533
Originally pull request #630